Repairs and potential bug

[gavin144]

From what I've gathered so far, repairs/building is now done by Space Docks (including ships like the ark, and maybe the starships?) and controllers and is indicated by a blue line.

So I just captured a Mk V Shield Starship, and it begun rebuilding the hull using the ark and the controller. After that was done it moved on to shields, which seemed to be going very slowly, so I decided to scrap some turrets and build a space dock. The space dock was created in it's self-building phase, but as soon as it was created started showing a blue repair line to the shield starship (and may be contributing the the shield regeneration?). I'm not sure if that's intended or not, I would have thought that during the build phase structures wouldn't be useful.

[gavin144]

Further checking shows that the space dock will not help build hull during it's build phase, but will help recharge shields.

Additionally the charging of the shields behaves very strangely. With 4 constructors, the shield initially seems to recharge at a rate of approximately 5/ui refresh, but initially you see no shield. After the shield appears (somewhere around 50,000/125,000 shield progress), the shield recharges at something more like 100/ui refresh.

[keith.lamothe]

I've put in a change to prevent stuff-still-under-construction from doing repairs, etc.

On the shield recharge rate oddities, I suspect when it was running low it was because you were out of metal. Repair takes metal, whether for hull or shield. I may need to change it but for now I'd like to try to make it work. The main thing needed there is for the drawn line to be a different color if the repair is running at a reduced rate due to metal starvation.

[gavin144]

I definitely wasn't running low on metal, since this sounds like unintended behavior, I've filed a bug report (#19010) with a save.