Evil Outpost on ocean shallows in the middle of an ocean

[dis astranagant]

I guess there's no way to get the wind off of this.  I tried surrounding it with buoys and building a shelter on a relatively close bit of shallows but nothing has worked.

[dis astranagant]

Swarms of nightmare octopi are bad enough when I'm not rapidly dying from the wind

[NyQuil]

I never checked, but does the wind hurt you while underwater?

[dis astranagant]

Seems to.  Ocean Shallows don't really have much water, though.

[x4000]

In for 1.054:

* Ocean shallows are no longer able to hold evil outposts or evil overlord lairs.
** This won't alter existing outposts/lairs, but it will prevent new ones from spawning in such a manner in new worlds.

Thanks!

[keith.lamothe]

In for 1.054:

* Ocean shallows are no longer able to hold evil outposts or evil overlord lairs.
** This won't alter existing outposts/lairs, but it will prevent new ones from spawning in such a manner in new worlds.

Thanks!

I had gotten halfway through doing that myself yesterday, but backed it out when I realized that there was already a rule that should prevent it (on the super-region-type-data).  But it may have only been working on the overlords, or I simply misunderstood it.

[x4000]

The rule on the super-regions doesn't prevent anything that I can see on that; the region type one prevented it on oceans and such, just not on ocean shallows, but now it definitely will.

[keith.lamothe]

The rule on the super-regions doesn't prevent anything that I can see on that; the region type one prevented it on oceans and such, just not on ocean shallows, but now it definitely will.

Region.cs:

Code: [Select]

                #region Evil Overlord Lairs/Lieutenant Outposts
                int superRegionsAlreadyOnContinent = Continent.CalculateCountOfSuperRegionsForContinent();
                if ( !isOriginRegion && superRegionsAlreadyOnContinent > 8 &&  //no evil overlords or evil outposts too close to the center of the continent
                    superRegion.TypeData.IsValidInSuperRegionCount ) //also don't put these in the invalid region types (water, lava, deep, etc, which are too mean)
(...)
IsValidInSuperRegionCount is false for the ocean super region type (and the deep, and lava).  And actually both the lieutenant and overlord logic is within that if's body, so I'm kind of puzzled that it was happening.  Ah well

[keith.lamothe]

Oh, I think I understand now: AddEvilOutpostAndLieutenant() is also called from InsureCorrectNumberOfLieutenantsOnContinent (insurance executives, they're everywhere!) and it just checks for water terrain, not for that super region flag, and iirc shallows doesn't count as water terrain in that sense.  But I'm looking at my working copy, not with your most recent changes, so you may have already nailed that

[x4000]

I didn't until just after your last post, but now in:

* Added in a further fix to prevent evil outposts that get added on upgrade of old worlds (to include 4 outposts instead of 3) to prevent them from seeding in bad locations like the deep, lava flats, oceans, etc.

[Gemzo]

Aw, an outpost in the deep wasn't thaaat bad. Can it possibly be an option to allow outposts/keeps in those places? That would make buoys a lot more useful, heh.

[x4000]

In a lot of cases with the ocean shallows it would make them impossible to traverse, unfortunately.

On the bright side, there tends to be ocean blocking you off from parts of the continent every so often, so that's something!

[Gemzo]

Well there's several potential fixes to that, if my suggestion was to be considered. Like buoys could lift storms on shallows if it has an outpost/keep on it, or just make shallows the only invalid location when this option is turned on. Maybe even allow shallows, but check if it's impossible to reach first.

And yeah I realize that, they're not useless, but ocean outposts/keeps would make them pretty indispensable.

[x4000]

I just don't think it's worth the complexity added, honestly.  Instead I went with something more dramatic:

* New continents now have more sections of ocean dividing them up, causing more of a need for buoys and your wind shelter networks than before.

[Gemzo]

Nice, that does work for making buoys more useful. But I still feel outposts/keeps in the deep/lava flats is not that bad. On the other hand, they aren't really needed either, they could make for some really nasty situations. Maybe I'm just feeling there needs to be more reasons to go to these places. The only reason I dipped my toes in the deep was because I had to go there, not because there's a chance to find fireworks. As for the lava flats, well, that indoor music is just too catchy. Err I mean I wanted an advanced heatsuit...and I got one and a ton of micro rex scrolls. Now I have no reason to go back and I am sad. I suppose this is the kind of thing you are already working on, so I'll stop rambling and go play the game. Cheers.